From 2bf9bd06215309174e2ca2e57171ddf8d7b3b18d Mon Sep 17 00:00:00 2001 From: strptrk Date: Wed, 1 Nov 2023 11:34:05 +0100 Subject: [PATCH] Fix firefox failing build (#217) Hi, After some experimentation and digging in the firefox repository I realized that the commas in _link-arg_ are the cause of the error. Also, correct me if I'm wrong here, but you do not have to pass -Wl to the linker, cargo handles that. Plus, according to the [documentation](https://doc.rust-lang.org/rustc/codegen-options/index.html#link-arg), it is possible to pass _link-arg_ multiple times to achieve the same result. I managed to build firefox locally with this change, so I guess this should work here as well. Reviewed-on: https://somegit.dev/ALHP/ALHP.GO/pulls/217 Co-authored-by: strptrk Co-committed-by: strptrk --- flags.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flags.yaml b/flags.yaml index 4d4276c..71faa61 100644 --- a/flags.yaml +++ b/flags.yaml @@ -20,7 +20,7 @@ common: packager: "ALHP $march$ " makeflags: "-j$buildproc$" # https://somegit.dev/ALHP/ALHP.GO/issues/110 - rustflags: "-Copt-level=3 -Ctarget-cpu=$march$ -Clink-arg=-Wl,-z,pack-relative-relocs" + rustflags: "-Copt-level=3 -Ctarget-cpu=$march$ -Clink-arg=-z -Clink-arg=pack-relative-relocs" ltoflags: - "-falign-functions=32" # https://github.com/InBetweenNames/gentooLTO/issues/164 kcflags: " -march=$march$ -O3"