From fd9f1d339f529bd66b46fad59f85ead4ccb8e9c5 Mon Sep 17 00:00:00 2001 From: Giovanni Harting <539@idlegandalf.com> Date: Sun, 26 Apr 2026 13:02:50 +0200 Subject: [PATCH] hold doneQLock when reading doneQ for unknown-mode heuristic --- buildmanager.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/buildmanager.go b/buildmanager.go index fc08648..59046d3 100644 --- a/buildmanager.go +++ b/buildmanager.go @@ -150,6 +150,7 @@ func (b *BuildManager) buildQueue(ctx context.Context, queue []*ProtoPackage) er } // if only unknown packages are left, enable unknown buildmode + doneQLock.RLock() b.buildingLock.RLock() if up == len(queue)-(len(doneQ)+len(b.building)) { // clear queueNoMatch on the transition so the next iteration @@ -161,6 +162,7 @@ func (b *BuildManager) buildQueue(ctx context.Context, queue []*ProtoPackage) er unknownBuilds = true } b.buildingLock.RUnlock() + doneQLock.RUnlock() } return nil }