ALHP/ALHP.GO
6
43
Fork 9
Code Issues 25 Pull Requests Projects Releases Wiki Activity

search-update #44

Merged
anonfunc merged 4 commits from vikingowl/ALHP.GO:search-update into master 2021-09-20 22:09:20 +02:00
Conversation 2 Commits 4 Files Changed 1 +55 -25
vikingowl commented 2021-09-20 17:07:41 +02:00
Contributor
Copy Link
  • Added SearchBar to NAV
  • Added Search-Feature to filter the tables
- Added SearchBar to NAV - Added Search-Feature to filter the tables
vikingowl added 2 commits 2021-09-20 17:07:42 +02:00
Search feature update d2eb990ace
removed test-tables 5606125c2a
anonfunc added the enhancement label 2021-09-20 17:18:39 +02:00
anonfunc requested changes 2021-09-20 18:25:16 +02:00
anonfunc left a comment
Owner
Copy Link

Thanks for your PR.
I would like some changes to make it more readable.

Going to test if all works later.

Thanks for your PR. I would like some changes to make it more readable. Going to test if all works later.
tpl/packages.html Outdated
@@ -25,0 +39,4 @@
placeholder="Search for packages.."
class="form-control"
id="table-sort-input"
onkeyup="myFunction()"
anonfunc commented 2021-09-20 18:21:02 +02:00
Owner
Copy Link

Please choose a more accurate function name.

Please choose a more accurate function name.
vikingowl marked this conversation as resolved
tpl/packages.html Outdated
@@ -93,0 +140,4 @@
integrity="sha384-U1DAWAznBHeqEIlVSCgzq+c9gqGAJn5c/t99JyeKa9xxaYpSvHU5awsuZVVFIhvj"
src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.0/dist/js/bootstrap.bundle.min.js"
></script>
<script>
anonfunc commented 2021-09-20 18:22:27 +02:00
Owner
Copy Link

See above.

See above.
vikingowl marked this conversation as resolved
vikingowl added 1 commit 2021-09-20 18:31:14 +02:00
change function name 4ca9bea711
anonfunc reviewed 2021-09-20 21:40:50 +02:00
tpl/packages.html Outdated
@@ -25,0 +40,4 @@
class="form-control"
id="table-sort-input"
onkeyup="searchFilter()"
placeholder="Search for names.."
anonfunc commented 2021-09-20 21:40:50 +02:00
Owner
Copy Link

Duplicate placeholder

Duplicate `placeholder`
anonfunc marked this conversation as resolved
vikingowl added 1 commit 2021-09-20 22:08:19 +02:00
final changes for search-function 0058dcff41
anonfunc merged commit c47d6f3cd2 into master 2021-09-20 22:09:20 +02:00
anonfunc referenced this issue from a commit 2021-09-20 22:09:20 +02:00
search-update (#44)
anonfunc deleted branch search-update 2021-10-24 05:05:01 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
anonfunc
Labels
Clear labels
blocked upstream
bug
Something is not working
 build-failure
package build fails
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 informational
Provides information about something
 invalid
Something is wrong
 invalid/corrupt package
Package needs to be rebuild
 packaging issue
priority: high
High priority
 question
More information is needed
 support
wontfix
This won't be fixed
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
anonfunc
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ALHP/ALHP.GO#44
Delete Branch "vikingowl/ALHP.GO:search-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?