ALHP/alhp-web
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vuetify-rework #2

Merged
anonfunc merged 18 commits from vuetify-rework into main 2024-01-24 16:11:55 +01:00
Conversation 3 Commits 18 Files Changed 28 +2135 -430
vikingowl commented 2024-01-24 00:07:04 +01:00
Collaborator
Copy Link

Ready for review

Ready for review
vikingowl added the enhancement label 2024-01-24 00:07:04 +01:00
vikingowl self-assigned this 2024-01-24 00:07:04 +01:00
anonfunc was assigned by vikingowl 2024-01-24 00:07:04 +01:00
vikingowl added 2 commits 2024-01-24 00:07:04 +01:00
init vuetify-rework 7f98d3587d
rebuild finished for testing 3c0981028c
vikingowl started working 2024-01-24 00:07:50 +01:00
vikingowl worked for 4 seconds 2024-01-24 00:07:54 +01:00
vikingowl added spent time 5 hours 2024-01-24 00:08:07 +01:00
vikingowl deleted spent time 2024-01-24 00:08:12 +01:00
- 4 seconds
anonfunc requested changes 2024-01-24 10:01:11 +01:00
anonfunc left a comment
Owner
Copy Link

Looks good overall, just some minor changes:

  • remove the favicon
  • drop the changes to the (main) readme
  • drop the (old) status.html in the root dir

Rest should be fine as far as I can see.

Looks good overall, just some minor changes: - remove the favicon - drop the changes to the (main) readme - drop the (old) status.html in the root dir Rest should be fine as far as I can see.
README.md Outdated
@@ -1,5 +1,5 @@
# ALHP Web
This project serves as backend for the ALHP API.
This project serves as backend for the ALHP API.
anonfunc commented 2024-01-24 09:49:48 +01:00
Owner
Copy Link

Please remove the tailing whitespace. Or better, drop the whole change to this file.

Please remove the tailing whitespace. Or better, drop the whole change to this file.
vikingowl marked this conversation as resolved
frontend/index.html
@@ -0,0 +4,4 @@
<head>
<meta charset="UTF-8" />
<link rel="icon" href="/favicon.ico" />
<link crossorigin="anonymous" href="https://cdn.jsdelivr.net/npm/fork-awesome@1.2.0/css/fork-awesome.min.css" integrity="sha256-XoaMnoYC5TH6/+ihMEnospgm0J1PM/nioxbOUdnM8HY=" rel="stylesheet">
anonfunc commented 2024-01-24 09:52:40 +01:00
Owner
Copy Link

I think we should serve this directly as dep without jsdeliver.

I think we should serve this directly as dep without jsdeliver.
vikingowl marked this conversation as resolved
vikingowl added 10 commits 2024-01-24 15:13:59 +01:00
added fork-awesome and prettier to project 63a91dbc83
reformat of code 3bfb87623d
removed favicon ea03a16adc
removed old html file 56208dd32c
fixed table icons being shifted 690d3da51a
moved build-stats from footer to nav 2470c7eb51
fixed broken pagination 38ff58b168
exported types f5c8d4fedf
added info-box for building and queued packages 5adfe88951
fixed font-size in packages table f7588ad57f
vikingowl added 1 commit 2024-01-24 15:18:43 +01:00
added variable for the update-interval f8295afc31
vikingowl added 1 commit 2024-01-24 15:46:02 +01:00
removed README.md 5161b0ab15
vikingowl added 1 commit 2024-01-24 15:46:43 +01:00
updated components.d.ts 38700911be
anonfunc approved these changes 2024-01-24 15:48:21 +01:00
anonfunc left a comment
Owner
Copy Link

LGTM. I'll quickly test locally and report back.

LGTM. I'll quickly test locally and report back.
👍 1 👀 1
vikingowl added 3 commits 2024-01-24 16:08:55 +01:00
added pulsar to card-title 0da3809c45
fixed broken package table de8a92746d
better describing text in queued list 587a8937a4
anonfunc commented 2024-01-24 16:11:29 +01:00
Owner
Copy Link

Some minor issues resolved via PM. Merging now.

Some minor issues resolved via PM. Merging now.
anonfunc merged commit db80961ea4 into main 2024-01-24 16:11:55 +01:00
anonfunc referenced this issue from a commit 2024-01-24 16:11:56 +01:00
vuetify-rework (#2)
vikingowl deleted branch vuetify-rework 2024-01-24 16:14:18 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
anonfunc
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
anonfunc vikingowl
No Assignees vikingowl anonfunc
2 Participants
Notifications
Total Time Spent: 5 hours
vikingowl
5 hours
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ALHP/alhp-web#2
Delete Branch "vuetify-rework"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?