CONTRIBUTING, git-terminal: explain common contrib issues (#7107)

This commit is contained in:
Sherman Hui
2021-10-27 10:51:53 -07:00
committed by GitHub
parent dfa9eebe1c
commit 8b531c09bb
3 changed files with 17 additions and 2 deletions

View File

@@ -106,6 +106,9 @@ Some examples of valid locale tags:
A list of translated templates for alias pages can be found in [here](contributing-guides/translation-templates/alias-pages.md).
Pull requests that introduce translations are the exception to the single file change per Pull Request rule. It is
acceptable for several pages to be translated in one pull request.
### Default language for newly added pages
The default language used for pages is English (US). Pages written in English are stored in the default `pages` directory (notice the absence of a specific language tag). Although not strictly required, if you'd like to add a new page in a different language, please consider creating the English page too.
@@ -124,6 +127,14 @@ Check out the step-by-step instructions (with screenshots) on
Alternatively, you can do most of the process
[using Git on the command-line](contributing-guides/git-terminal.md).
### Accepting suggestions within a pull request
The easiest way to apply suggested changes is to accept the suggestion made on your pull request. Refer to the [GitHub docs](https://docs.github.com/en/enterprise-server@3.2/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request) for more details.
To commit a suggestion to your pull request, simply click on `Commit suggestion`:
![Commit suggestion button in Github](./images/commit-suggestion-button.png)
### Commit message
For the commit message, use the following format: