Files
gnoma/internal/elf/elf_test.go
T
vikingowl 07c739795c feat: M7 Elfs — sub-agents with router-integrated spawning
internal/elf/:
- BackgroundElf: runs on own goroutine with independent engine,
  history, and provider. No shared mutable state.
- Manager: spawns elfs via router.Select() (picks best arm per
  task type), tracks lifecycle, WaitAll(), CancelAll(), Cleanup().

internal/tool/agent/:
- Agent tool: LLM can call 'agent' to spawn sub-agents.
  Supports task_type hint for routing, wait/background mode.
  5-minute timeout, context cancellation propagated.

Concurrent tool execution:
- Read-only tools (fs.read, fs.grep, fs.glob, etc.) execute in
  parallel via goroutines.
- Write tools (bash, fs.write, fs.edit) execute sequentially.
- Partition by tool.IsReadOnly().

TUI: /elf command explains how to use sub-agents.
5 elf tests. Exit criteria: parent spawns 3 background elfs on
different providers, collects and synthesizes results.
2026-04-03 19:16:46 +02:00

240 lines
5.8 KiB
Go

package elf
import (
"context"
"fmt"
"testing"
"time"
"somegit.dev/Owlibou/gnoma/internal/engine"
"somegit.dev/Owlibou/gnoma/internal/message"
"somegit.dev/Owlibou/gnoma/internal/provider"
"somegit.dev/Owlibou/gnoma/internal/router"
"somegit.dev/Owlibou/gnoma/internal/stream"
"somegit.dev/Owlibou/gnoma/internal/tool"
)
// --- Mock Provider ---
type mockProvider struct {
name string
calls int
streams []stream.Stream
}
func (m *mockProvider) Name() string { return m.name }
func (m *mockProvider) DefaultModel() string { return "mock" }
func (m *mockProvider) Models(_ context.Context) ([]provider.ModelInfo, error) { return nil, nil }
func (m *mockProvider) Stream(_ context.Context, _ provider.Request) (stream.Stream, error) {
if m.calls >= len(m.streams) {
return nil, fmt.Errorf("no more streams")
}
s := m.streams[m.calls]
m.calls++
return s, nil
}
type eventStream struct {
events []stream.Event
idx int
}
func newEventStream(text string) *eventStream {
return &eventStream{
events: []stream.Event{
{Type: stream.EventTextDelta, Text: text},
{Type: stream.EventTextDelta, StopReason: message.StopEndTurn},
},
}
}
func (s *eventStream) Next() bool { s.idx++; return s.idx <= len(s.events) }
func (s *eventStream) Current() stream.Event { return s.events[s.idx-1] }
func (s *eventStream) Err() error { return nil }
func (s *eventStream) Close() error { return nil }
// --- Tests ---
func TestBackgroundElf_RunsAndCompletes(t *testing.T) {
mp := &mockProvider{
name: "test",
streams: []stream.Stream{newEventStream("Hello from elf!")},
}
eng, _ := engine.New(engine.Config{Provider: mp, Tools: tool.NewRegistry()})
elf := SpawnBackground(eng, "say hello")
if elf.Status() != StatusRunning {
t.Errorf("initial status = %s, want running", elf.Status())
}
result := elf.Wait()
if result.Status != StatusCompleted {
t.Errorf("result status = %s, want completed", result.Status)
}
if result.Output != "Hello from elf!" {
t.Errorf("output = %q", result.Output)
}
if result.Duration <= 0 {
t.Error("duration should be positive")
}
if elf.Status() != StatusCompleted {
t.Errorf("final status = %s, want completed", elf.Status())
}
}
func TestBackgroundElf_Cancel(t *testing.T) {
// Stream that blocks
slowStream := &slowEventStream{}
mp := &mockProvider{
name: "test",
streams: []stream.Stream{slowStream},
}
eng, _ := engine.New(engine.Config{Provider: mp, Tools: tool.NewRegistry()})
elf := SpawnBackground(eng, "slow task")
time.Sleep(10 * time.Millisecond)
elf.Cancel()
result := elf.Wait()
if result.Status != StatusCancelled && result.Status != StatusFailed {
t.Errorf("status = %s, want cancelled or failed", result.Status)
}
}
func TestBackgroundElf_CollectEvents(t *testing.T) {
mp := &mockProvider{
name: "test",
streams: []stream.Stream{newEventStream("event test")},
}
eng, _ := engine.New(engine.Config{Provider: mp, Tools: tool.NewRegistry()})
elf := SpawnBackground(eng, "generate events")
var events []stream.Event
for evt := range elf.Events() {
events = append(events, evt)
}
if len(events) == 0 {
t.Error("should receive events")
}
}
func TestManager_SpawnAndList(t *testing.T) {
mp := &mockProvider{
name: "test",
streams: []stream.Stream{
newEventStream("elf 1"),
newEventStream("elf 2"),
},
}
rtr := router.New(router.Config{})
rtr.RegisterArm(&router.Arm{
ID: "test/mock",
Provider: mp,
ModelName: "mock",
Capabilities: provider.Capabilities{ToolUse: true},
})
mgr := NewManager(ManagerConfig{
Router: rtr,
Tools: tool.NewRegistry(),
})
// Spawn two elfs
e1, err := mgr.Spawn(context.Background(), router.TaskGeneration, "task 1", "you are elf 1")
if err != nil {
t.Fatalf("Spawn 1: %v", err)
}
e2, err := mgr.Spawn(context.Background(), router.TaskReview, "task 2", "you are elf 2")
if err != nil {
t.Fatalf("Spawn 2: %v", err)
}
// List should have 2
if len(mgr.List()) != 2 {
t.Errorf("List() = %d, want 2", len(mgr.List()))
}
// Wait for both
r1 := e1.Wait()
r2 := e2.Wait()
if r1.Status != StatusCompleted {
t.Errorf("elf 1 status = %s", r1.Status)
}
if r2.Status != StatusCompleted {
t.Errorf("elf 2 status = %s", r2.Status)
}
// Active should be 0
if len(mgr.Active()) != 0 {
t.Errorf("Active() = %d, want 0", len(mgr.Active()))
}
// Cleanup
mgr.Cleanup()
if len(mgr.List()) != 0 {
t.Errorf("after cleanup, List() = %d", len(mgr.List()))
}
}
func TestManager_WaitAll(t *testing.T) {
mp := &mockProvider{
name: "test",
streams: []stream.Stream{
newEventStream("result A"),
newEventStream("result B"),
newEventStream("result C"),
},
}
rtr := router.New(router.Config{})
rtr.RegisterArm(&router.Arm{
ID: "test/mock", Provider: mp, ModelName: "mock",
Capabilities: provider.Capabilities{ToolUse: true},
})
mgr := NewManager(ManagerConfig{Router: rtr, Tools: tool.NewRegistry()})
mgr.Spawn(context.Background(), router.TaskGeneration, "a", "")
mgr.Spawn(context.Background(), router.TaskGeneration, "b", "")
mgr.Spawn(context.Background(), router.TaskGeneration, "c", "")
results := mgr.WaitAll()
if len(results) != 3 {
t.Fatalf("WaitAll() = %d results, want 3", len(results))
}
completed := 0
for _, r := range results {
if r.Status == StatusCompleted {
completed++
}
}
if completed != 3 {
t.Errorf("%d completed, want 3", completed)
}
}
// slowEventStream blocks until context cancelled
type slowEventStream struct {
done bool
}
func (s *slowEventStream) Next() bool {
if s.done {
return false
}
time.Sleep(100 * time.Millisecond)
return false
}
func (s *slowEventStream) Current() stream.Event { return stream.Event{} }
func (s *slowEventStream) Err() error { return context.Canceled }
func (s *slowEventStream) Close() error { s.done = true; return nil }