️ perf(cut): unnecessary cmake code

This commit is contained in:
Eshan Roy
2024-11-19 05:09:18 +05:30
parent 7e136151f5
commit 04ae7dfb34

View File

@@ -13,10 +13,10 @@ find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets)
find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets) find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets)
set(PROJECT_SOURCES set(PROJECT_SOURCES
main.cpp qt/main.cpp
snigdhaosblackbox.cpp qt/snigdhaosblackbox.cpp
snigdhaosblackbox.h qt/snigdhaosblackbox.h
snigdhaosblackbox.ui qt/snigdhaosblackbox.ui
) )
if(${QT_VERSION_MAJOR} GREATER_EQUAL 6) if(${QT_VERSION_MAJOR} GREATER_EQUAL 6)
@@ -28,41 +28,48 @@ if(${QT_VERSION_MAJOR} GREATER_EQUAL 6)
# set_property(TARGET SnigdhaOSBlackbox APPEND PROPERTY QT_ANDROID_PACKAGE_SOURCE_DIR # set_property(TARGET SnigdhaOSBlackbox APPEND PROPERTY QT_ANDROID_PACKAGE_SOURCE_DIR
# ${CMAKE_CURRENT_SOURCE_DIR}/android) # ${CMAKE_CURRENT_SOURCE_DIR}/android)
# For more information, see https://doc.qt.io/qt-6/qt-add-executable.html#target-creation # For more information, see https://doc.qt.io/qt-6/qt-add-executable.html#target-creation
else() # else()
if(ANDROID) # if(ANDROID)
add_library(SnigdhaOSBlackbox SHARED # add_library(SnigdhaOSBlackbox SHARED
${PROJECT_SOURCES} # ${PROJECT_SOURCES}
) # )
# Define properties for Android with Qt 5 after find_package() calls as: # Define properties for Android with Qt 5 after find_package() calls as:
# set(ANDROID_PACKAGE_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/android") # set(ANDROID_PACKAGE_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/android")
else() # else()
# add_executable(SnigdhaOSBlackbox
# ${PROJECT_SOURCES}
# )
# endif()
# endif()
else()
add_executable(SnigdhaOSBlackbox add_executable(SnigdhaOSBlackbox
${PROJECT_SOURCES} ${PROJECT_SOURCES}
) )
endif()
endif() endif()
target_link_libraries(SnigdhaOSBlackbox PRIVATE Qt${QT_VERSION_MAJOR}::Widgets)
target_link_libraries(SnigdhaOSBlackbox PRIVATE Qt${QT_VERSION_MAJOR}::Widgets Qt${QT_VERSION_MAJOR}::Network)
# Qt for iOS sets MACOSX_BUNDLE_GUI_IDENTIFIER automatically since Qt 6.1. # Qt for iOS sets MACOSX_BUNDLE_GUI_IDENTIFIER automatically since Qt 6.1.
# If you are developing for iOS or macOS you should consider setting an # If you are developing for iOS or macOS you should consider setting an
# explicit, fixed bundle identifier manually though. # explicit, fixed bundle identifier manually though.
if(${QT_VERSION} VERSION_LESS 6.1.0) # if(${QT_VERSION} VERSION_LESS 6.1.0)
set(BUNDLE_ID_OPTION MACOSX_BUNDLE_GUI_IDENTIFIER com.example.SnigdhaOSBlackbox) # set(BUNDLE_ID_OPTION MACOSX_BUNDLE_GUI_IDENTIFIER com.example.SnigdhaOSBlackbox)
endif() # endif()
set_target_properties(SnigdhaOSBlackbox PROPERTIES # set_target_properties(SnigdhaOSBlackbox PROPERTIES
${BUNDLE_ID_OPTION} # ${BUNDLE_ID_OPTION}
MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION} # MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION}
MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR} # MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}
MACOSX_BUNDLE TRUE # MACOSX_BUNDLE TRUE
WIN32_EXECUTABLE TRUE # WIN32_EXECUTABLE TRUE
) # )
include(GNUInstallDirs) # include(GNUInstallDirs)
install(TARGETS SnigdhaOSBlackbox install(TARGETS SnigdhaOSBlackbox
BUNDLE DESTINATION . BUNDLE DESTINATION .
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} # RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
) )
if(QT_VERSION_MAJOR EQUAL 6) if(QT_VERSION_MAJOR EQUAL 6)