added golangci linter; code cleanup

This commit is contained in:
2022-11-20 19:19:16 +01:00
parent e58a6a3ad7
commit ff21894aac
7 changed files with 293 additions and 210 deletions

View File

@@ -54,13 +54,14 @@ func (pkg Package) Arch() string {
// HasValidSignature returns if package has valid detached signature file
func (pkg Package) HasValidSignature() (bool, error) {
cmd := exec.Command("gpg", "--verify", string(pkg)+".sig")
cmd := exec.Command("gpg", "--verify", string(pkg)+".sig") //nolint:gosec
res, err := cmd.CombinedOutput()
if cmd.ProcessState.ExitCode() == 2 || cmd.ProcessState.ExitCode() == 1 {
switch {
case cmd.ProcessState.ExitCode() == 2 || cmd.ProcessState.ExitCode() == 1:
return false, nil
} else if cmd.ProcessState.ExitCode() == 0 {
case cmd.ProcessState.ExitCode() == 0:
return true, nil
} else if err != nil {
case err != nil:
return false, fmt.Errorf("error checking signature: %w (%s)", err, res)
}