TAIGA/TAIGA
3
1
Fork 4
Code Issues 16 Pull Requests Projects Releases Wiki Activity

Fixed Heroic, obsidiorite #2

Closed
Jotunn wants to merge 1 commits from Jotunn/TAIGA-Obsidiorite-Heroic-Fixes:master into master
pull from: Jotunn/TAIGA-Obsidiorite-Heroic-Fixes:master
merge into: TAIGA:master
Conversation 3 Commits 1 Files Changed 5 +42 -16
Jotunn commented 2019-10-13 19:26:33 +02:00
First-time contributor
Copy Link
No description provided.
🎉 1
anonfunc commented 2019-10-13 22:45:28 +02:00
Owner
Copy Link

Hi!

Good to see you got here in the end :)

Just some questions (see review below).

Hi! Good to see you got here in the end :) Just some questions (see review below).
anonfunc added the
changes requested
 label 2019-10-13 22:48:05 +02:00
anonfunc self-assigned this 2019-10-13 22:51:02 +02:00
anonfunc requested changes 2019-10-13 22:53:08 +02:00
anonfunc left a comment
Owner
Copy Link

Is META-INF/MANIFEST.MF required? Did I missing something in forge?

Is META-INF/MANIFEST.MF required? Did I missing something in forge?
src/main/java/com/sosnitzka/taiga/traits/TraitHeroic.java
@@ -33,2 +26,4 @@
} else return super.damage(tool, player, target, damage, newDamage * 0.9f, isCritical);
}
private int noLessThanOne(int input){
anonfunc commented 2019-10-13 22:43:21 +02:00
Owner
Copy Link

You don't need that, just use Math.max(durabilitymax - durability - 1, 1).

You don't need that, just use ```Math.max(durabilitymax - durability - 1, 1)```.
anonfunc commented 2019-10-13 23:01:08 +02:00
Owner
Copy Link

On second thought, maybe that whole logic is flawed. durabilitymax - durability should always be >= 0, right? So just changing that to Math.max(durabilitymax - durability, 1) would do it, if I'm not mistaken.

We need to be careful here to not change behaviour accidentally, since this part was written by Zkaface, so I'm not quite sure about the mechanics.

On second thought, maybe that whole logic is flawed. ```durabilitymax - durability``` should always be >= 0, right? So just changing that to ```Math.max(durabilitymax - durability, 1)``` would do it, if I'm not mistaken. We need to be careful here to not change behaviour accidentally, since this part was written by Zkaface, so I'm not quite sure about the mechanics.
anonfunc commented 2024-06-16 13:10:49 +02:00
Owner
Copy Link

Closing this as stale.

Closing this as stale.
anonfunc closed this pull request 2024-06-16 13:10:49 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
anonfunc
Labels
Clear labels
bug
Something is not working
changes requested
PR was reviewed and changes are necessary
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
changes requested
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
anonfunc Zkaface
No Assignees anonfunc
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TAIGA/TAIGA#2
No description provided.
Delete Branch "Jotunn/TAIGA-Obsidiorite-Heroic-Fixes:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?