anonfunc/usteer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

local-node: don't read pointer after clear

Browse Source 
The name pointer provided by ubus get's cleared after the first call to
ubus_register_subscriber in usteer_get_node. The leads to an incorrect
ifindex returned by if_nametoindex due to the 0 characters long string.

Work around this issue by reusing the interface name already stored in
the local node struct.

Fixes querying the wrong interface with netlink, resulting in incorrect
SSIDs used for the nodes.

Signed-off-by: David Bauer <mail@david-bauer.net>
This commit is contained in:
David Bauer
2021-09-21 18:51:57 +02:00
parent e4ea2045eb
commit 8c35c8e6a0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
local_node.c
View File

@@ -447,7 +447,7 @@ usteer_register_node(struct ubus_context *ctx, const char *name, uint32_t id)
ln = usteer_get_node(ctx, name); ln = usteer_get_node(ctx, name);
ln->obj_id = id; ln->obj_id = id;
ln->iface = usteer_node_name(&ln->node) + offset; ln->iface = usteer_node_name(&ln->node) + offset;
ln->ifindex = if_nametoindex(iface); ln->ifindex = if_nametoindex(ln->iface);
blob_buf_init(&b, 0); blob_buf_init(&b, 0);
blobmsg_add_u32(&b, "notify_response", 1); blobmsg_add_u32(&b, "notify_response", 1);