Files
usteer/node.c
David Bauer 5ec713b8f3 node: determine roamability when selecting neighbors
Currently, the neighbor report list is sorted based on the total amount
of roam actions to and from the specific foreign nodes.

This does not take into account that nodes might not be created at the
same time. When a popular neighbor node reboots, it's roam actions are
reset and it's ranking might not recover for a long amount of time
depending on how long the local node is already running.

Change this shotcoming to take into account the timestamp at which a
node was created. This way, the ranking depends on the amount of roam
actions relative to the nodes uptime / seen-time.

Signed-off-by: David Bauer <mail@david-bauer.net>
2021-11-25 22:28:57 +01:00

144 lines
3.6 KiB
C

/*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
*
* Copyright (C) 2020 embedd.ch
* Copyright (C) 2020 Felix Fietkau <nbd@nbd.name>
* Copyright (C) 2020 John Crispin <john@phrozen.org>
*/
#include "node.h"
#include "usteer.h"
void usteer_node_set_blob(struct blob_attr **dest, struct blob_attr *val)
{
int new_len;
int len;
if (!val) {
free(*dest);
*dest = NULL;
return;
}
len = *dest ? blob_pad_len(*dest) : 0;
new_len = blob_pad_len(val);
if (new_len != len)
*dest = realloc(*dest, new_len);
memcpy(*dest, val, new_len);
}
static struct usteer_node *
usteer_node_higher_bssid(struct usteer_node *node1, struct usteer_node *node2)
{
int i;
for (i = 0; i < 6; i++) {
if (node1->bssid[i] == node2->bssid[i])
continue;
if (node1->bssid[i] < node2->bssid[i])
return node2;
break;
}
return node1;
}
static struct usteer_node *
usteer_node_higher_roamability(struct usteer_node *node, struct usteer_node *ref)
{
uint64_t roamability_node, roamability_ref;
roamability_node = ((uint64_t)(node->roam_source + node->roam_destination)) * current_time / ((current_time - node->created) + 1);
roamability_ref = ((uint64_t)(ref->roam_source + ref->roam_destination)) * current_time / ((current_time - ref->created) + 1);
if (roamability_node < roamability_ref)
return ref;
return node;
}
static struct usteer_node *
usteer_node_better_neighbor(struct usteer_node *node, struct usteer_node *ref)
{
struct usteer_node *n1, *n2;
/**
* 1. Return one node if the other one is NULL
* 2. Return the node with the higher roam events.
* 3. Return the node with the higher BSSID.
* 4. Return first method argument.
*/
if (!ref)
return node;
if (!node)
return ref;
n1 = usteer_node_higher_roamability(node, ref);
n2 = usteer_node_higher_roamability(ref, node);
if (n1 == n2)
return n1;
/* Identical roam interactions. Check BSSID */
n1 = usteer_node_higher_bssid(node, ref);
n2 = usteer_node_higher_bssid(ref, node);
if (n1 == n2)
return n1;
return node;
}
struct usteer_node *
usteer_node_get_next_neighbor(struct usteer_node *current_node, struct usteer_node *last)
{
struct usteer_remote_node *rn;
struct usteer_node *next = NULL, *n1, *n2;
for_each_remote_node(rn) {
if (next == &rn->node)
continue;
if (strcmp(current_node->ssid, rn->node.ssid))
continue;
/* Check if this node is ranked lower than the last one */
n1 = usteer_node_better_neighbor(last, &rn->node);
n2 = usteer_node_better_neighbor(&rn->node, last);
if (n1 != n2) {
/* Identical rank. Skip. */
continue;
} else if (last && n1 == &rn->node) {
/* Candidate rank is higher than the last neighbor. Skip. */
continue;
}
/* Check with current next candidate */
n1 = usteer_node_better_neighbor(next, &rn->node);
n2 = usteer_node_better_neighbor(&rn->node, next);
if (n1 != n2) {
/* Identical rank. Skip. */
continue;
} else if (n1 != &rn->node) {
/* Next candidate ranked higher. */
continue;
}
next = n1;
}
return next;
}