From 0a836e96772e34d623f23fb286a78705ae17a3fa Mon Sep 17 00:00:00 2001
From: Jan Engelhardt <jengelh@inai.de>
Date: Sun, 23 Jul 2017 19:55:06 +0200
Subject: [PATCH] pknock: fix PVSStudio static analyzer reports

V595 The 'peer' pointer was utilized before it was verified against
nullptr.
---
 extensions/pknock/xt_pknock.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/extensions/pknock/xt_pknock.c b/extensions/pknock/xt_pknock.c
index d4a835f..6fbdea4 100644
--- a/extensions/pknock/xt_pknock.c
+++ b/extensions/pknock/xt_pknock.c
@@ -619,9 +619,10 @@ static void add_peer(struct peer *peer, struct xt_pknock_rule *rule)
  */
 static void remove_peer(struct peer *peer)
 {
+	if (peer == NULL)
+		return;
 	list_del(&peer->head);
-	if (peer != NULL)
-		kfree(peer);
+	kfree(peer);
 }
 
 /**