anonfunc/xtables-addons
1
0
Fork 0
mirror of git://git.code.sf.net/p/xtables-addons/xtables-addons synced 2025-09-08 13:44:56 +02:00
Code Issues Releases Wiki Activity

pknock: add_rule must happen after info struct checks

Browse Source 
This avoids unnecessarily creating pknock rules if there is an error
with any of the match parameters.
This commit is contained in:
Jan Engelhardt
2009-10-07 00:40:19 +02:00
parent c2c86f4b3d
commit 204b612e23
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/xt_pknock.c
View File

@@ -1034,9 +1034,6 @@ static bool pknock_mt_check(const struct xt_mtchk_param *par)
get_random_bytes(&ipt_pknock_hash_rnd, sizeof (ipt_pknock_hash_rnd)); get_random_bytes(&ipt_pknock_hash_rnd, sizeof (ipt_pknock_hash_rnd));
} }
if (!add_rule(info))
RETURN_ERR("add_rule() error in checkentry() function.\n");
if (!(info->option & XT_PKNOCK_NAME)) if (!(info->option & XT_PKNOCK_NAME))
RETURN_ERR("You must specify --name option.\n"); RETURN_ERR("You must specify --name option.\n");
@@ -1081,6 +1078,9 @@ static bool pknock_mt_check(const struct xt_mtchk_param *par)
} }
#endif #endif
if (!add_rule(info))
RETURN_ERR("add_rule() error in checkentry() function.\n");
return true; return true;
} }