anonfunc/xtables-addons
1
0
Fork 0
mirror of git://git.code.sf.net/p/xtables-addons/xtables-addons synced 2025-09-08 21:54:57 +02:00
Code Issues Releases Wiki Activity

xt_condition: remove unnecessary RCU protection

Browse Source 
The module does not use the RCU mechanism, so calling
list_add_rcu/list_del_rcu does not make much sense either.
This commit is contained in:
Jan Engelhardt
2010-04-09 12:25:30 +02:00
parent 79c55ab325
commit 47cbb07162
2 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
doc/changelog.txt
View File

@@ -9,6 +9,7 @@ HEAD
- TEE: do not retain iif and mark on cloned packet - TEE: do not retain iif and mark on cloned packet
- TEE: new loop detection logic - TEE: new loop detection logic
- TEE: use less expensive pskb_copy - TEE: use less expensive pskb_copy
- condition: remove unnecessary RCU protection
Xtables-addons 1.24 (March 17 2010) Xtables-addons 1.24 (March 17 2010)

18
extensions/xt_condition.c
View File

@@ -100,13 +100,8 @@ condition_mt(const struct sk_buff *skb, const struct xt_match_param *par)
{ {
const struct xt_condition_mtinfo *info = par->matchinfo; const struct xt_condition_mtinfo *info = par->matchinfo;
const struct condition_variable *var = info->condvar; const struct condition_variable *var = info->condvar;
bool x;
rcu_read_lock(); return var->enabled ^ info->invert;
x = rcu_dereference(var->enabled);
rcu_read_unlock();
return x ^ info->invert;
} }
static int condition_mt_check(const struct xt_mtchk_param *par) static int condition_mt_check(const struct xt_mtchk_param *par)
@@ -164,7 +159,7 @@ static int condition_mt_check(const struct xt_mtchk_param *par)
wmb(); wmb();
var->status_proc->read_proc = condition_proc_read; var->status_proc->read_proc = condition_proc_read;
var->status_proc->write_proc = condition_proc_write; var->status_proc->write_proc = condition_proc_write;
list_add_rcu(&var->list, &conditions_list); list_add(&var->list, &conditions_list);
var->status_proc->uid = condition_uid_perms; var->status_proc->uid = condition_uid_perms;
var->status_proc->gid = condition_gid_perms; var->status_proc->gid = condition_gid_perms;
mutex_unlock(&proc_lock); mutex_unlock(&proc_lock);
@@ -179,16 +174,9 @@ static void condition_mt_destroy(const struct xt_mtdtor_param *par)
mutex_lock(&proc_lock); mutex_lock(&proc_lock);
if (--var->refcount == 0) { if (--var->refcount == 0) {
list_del_rcu(&var->list); list_del(&var->list);
remove_proc_entry(var->status_proc->name, proc_net_condition); remove_proc_entry(var->status_proc->name, proc_net_condition);
mutex_unlock(&proc_lock); mutex_unlock(&proc_lock);
/*
* synchronize_rcu() would be good enough, but
* synchronize_net() guarantees that no packet
* will go out with the old rule after
* succesful removal.
*/
synchronize_net();
kfree(var); kfree(var);
return; return;
} }