From 4997b326f67a2304469e84055465a9fc1cc6711d Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Sun, 5 Apr 2009 10:36:16 +0200 Subject: [PATCH] fuzzy: fix bogus comparison logic leftover from move to new 1.4.3 API --- doc/changelog.txt | 3 +++ extensions/libxt_fuzzy.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/changelog.txt b/doc/changelog.txt index e3a223f..412701a 100644 --- a/doc/changelog.txt +++ b/doc/changelog.txt @@ -1,5 +1,8 @@ +- fuzzy: fix bogus comparison logic leftover from move to new 1.4.3 API + + Xtables-addons 1.14 (March 31 2009) =================================== - fuzzy: need to account for kernel-level modified variables in .userspacesize diff --git a/extensions/libxt_fuzzy.c b/extensions/libxt_fuzzy.c index c2b96fe..2353104 100644 --- a/extensions/libxt_fuzzy.c +++ b/extensions/libxt_fuzzy.c @@ -58,7 +58,7 @@ static int fuzzy_mt_parse(int c, char **argv, int invert, unsigned int *flags, xtables_error(PARAMETER_PROBLEM,"Can't specify ! --lower-limit"); if (*flags & IPT_FUZZY_OPT_MINIMUM) xtables_error(PARAMETER_PROBLEM,"Can't specify --lower-limit twice"); - if (!xtables_strtoui(optarg, NULL, &num, 1, FUZZY_MAX_RATE) == -1 || num < 1) + if (!xtables_strtoui(optarg, NULL, &num, 1, FUZZY_MAX_RATE) || num < 1) xtables_error(PARAMETER_PROBLEM,"BAD --lower-limit"); info->minimum_rate = num; *flags |= IPT_FUZZY_OPT_MINIMUM; @@ -69,7 +69,7 @@ static int fuzzy_mt_parse(int c, char **argv, int invert, unsigned int *flags, xtables_error(PARAMETER_PROBLEM,"Can't specify ! --upper-limit"); if (*flags & IPT_FUZZY_OPT_MAXIMUM) xtables_error(PARAMETER_PROBLEM,"Can't specify --upper-limit twice"); - if (!xtables_strtoui(optarg, NULL, &num, 1, FUZZY_MAX_RATE) == -1 || num < 1) + if (!xtables_strtoui(optarg, NULL, &num, 1, FUZZY_MAX_RATE) || num < 1) xtables_error(PARAMETER_PROBLEM,"BAD --upper-limit"); info->maximum_rate = num; *flags |= IPT_FUZZY_OPT_MAXIMUM;