From 9c43965a86af4daa8fee93c0cc95408bf5721653 Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Fri, 19 Sep 2008 17:10:23 -0400 Subject: [PATCH] Resolve compiler warnings in xt_ECHO Reported-by: Jiri Moravec --- extensions/xt_ECHO.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/extensions/xt_ECHO.c b/extensions/xt_ECHO.c index 38d8e90..9b024eb 100644 --- a/extensions/xt_ECHO.c +++ b/extensions/xt_ECHO.c @@ -34,7 +34,7 @@ static unsigned int echo_tg4(struct sk_buff **poldskb, void *payload; /* This allows us to do the copy operation in fewer lines of code. */ - if (skb_linearize(oldskb) < 0) + if (skb_linearize(*poldskb) < 0) return NF_DROP; oldip = ip_hdr(oldskb); @@ -87,7 +87,7 @@ static unsigned int echo_tg4(struct sk_buff **poldskb, dst_hold(oldskb->dst); newskb->dst = oldskb->dst; - if (ip_route_me_harder(newskb, addr_type) < 0) + if (ip_route_me_harder(&newskb, addr_type) < 0) goto free_nskb; newip->ttl = dst_metric(newskb->dst, RTAX_HOPLIMIT); @@ -97,7 +97,7 @@ static unsigned int echo_tg4(struct sk_buff **poldskb, if (newskb->len > dst_mtu(newskb->dst)) goto free_nskb; - nf_ct_attach(newskb, oldskb); + nf_ct_attach(newskb, *poldskb); ip_local_out(newskb); return NF_DROP; @@ -129,7 +129,7 @@ static void __exit echo_tg_exit(void) module_init(echo_tg_init); module_exit(echo_tg_exit); -MODULE_AUTHOR("Jan Engelhardt "); +MODULE_AUTHOR("Jan Engelhardt "); MODULE_DESCRIPTION("Xtables: ECHO diagnosis target"); MODULE_LICENSE("GPL"); MODULE_ALIAS("ipt_ECHO");