anonfunc/xtables-addons
1
0
Fork 0
mirror of git://git.code.sf.net/p/xtables-addons/xtables-addons synced 2025-09-08 05:34:58 +02:00
Code Issues Releases Wiki Activity

geoip: add missing kfree in error path

Browse Source
This commit is contained in:
Jan Engelhardt
2008-03-17 14:11:26 +01:00
parent d480ea2b1f
commit df063ab61c
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
extensions/xt_geoip.c
View File

@@ -35,12 +35,16 @@ static struct geoip_info *add_node(struct geoip_info *memcpy)
struct geoip_subnet *s; struct geoip_subnet *s;
if ((p == NULL) || (copy_from_user(p, memcpy, sizeof(struct geoip_info)) != 0)) if (p == NULL)
return NULL; return NULL;
if (copy_from_user(p, memcpy, sizeof(struct geoip_info)) != 0)
goto free_p;
s = kmalloc(p->count * sizeof(struct geoip_subnet), GFP_KERNEL); s = kmalloc(p->count * sizeof(struct geoip_subnet), GFP_KERNEL);
if ((s == NULL) || (copy_from_user(s, p->subnets, p->count * sizeof(struct geoip_subnet)) != 0)) if (s == NULL)
return NULL; goto free_p;
if (copy_from_user(s, p->subnets, p->count * sizeof(struct geoip_subnet)) != 0)
goto free_s;
spin_lock_bh(&geoip_lock); spin_lock_bh(&geoip_lock);
@@ -54,6 +58,11 @@ static struct geoip_info *add_node(struct geoip_info *memcpy)
spin_unlock_bh(&geoip_lock); spin_unlock_bh(&geoip_lock);
return p; return p;
free_s:
kfree(s);
free_p:
kfree(p);
return NULL;
} }
static void remove_node(struct geoip_info *p) static void remove_node(struct geoip_info *p)