diff --git a/extensions/libxt_iface.c b/extensions/libxt_iface.c index 2bf4533..9033279 100644 --- a/extensions/libxt_iface.c +++ b/extensions/libxt_iface.c @@ -62,7 +62,7 @@ static bool iface_valid_name(const char *name) { char invalid_chars[] = ".+!*"; - return !((strlen(name) >= IFNAMSIZ) || (strcspn(name, invalid_chars) != strlen(name))); + return !(strlen(name) >= IFNAMSIZ || strcspn(name, invalid_chars) != strlen(name)); } static void iface_mt_help(void) @@ -158,7 +158,7 @@ static void iface_mt_check(unsigned int flags) if (!(flags & XT_IFACE_IFACE)) xtables_error(PARAMETER_PROBLEM, "iface: You must specify an interface"); - if ((flags == 0) || (flags == XT_IFACE_IFACE)) + if (flags == 0 || flags == XT_IFACE_IFACE) xtables_error(PARAMETER_PROBLEM, "iface: You must specify at least one option"); } diff --git a/extensions/xt_iface.c b/extensions/xt_iface.c index 6d4b2fc..e0da78e 100644 --- a/extensions/xt_iface.c +++ b/extensions/xt_iface.c @@ -43,15 +43,14 @@ static bool xt_iface_mt(const struct sk_buff *skb, int i; retval = - ((dev = dev_get_by_name(&init_net, info->ifname)) != NULL); + (dev = dev_get_by_name(&init_net, info->ifname)) != NULL; if (retval) { - for (i=0; (iflags & xt_iface_lookup[i].iface_flag) retval = retval && (dev->flags & xt_iface_lookup[i].iff_flag); if (info->invflags & xt_iface_lookup[i].iface_flag) retval = retval && !(dev->flags & xt_iface_lookup[i].iff_flag); - } + } dev_put(dev); } return retval;