anonfunc/xtables-addons
1
0
Fork 0
mirror of git://git.code.sf.net/p/xtables-addons/xtables-addons synced 2025-09-17 18:14:57 +02:00
Code Issues Releases Wiki Activity

pknock: use explicit tests for non-bool types

Browse Source
This commit is contained in:
Jan Engelhardt
2009-09-30 01:26:06 +02:00
parent 79d54ebd7c
commit e436948ebd
2 changed files with 24 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
extensions/libxt_pknock.c
View File

@@ -61,16 +61,19 @@ parse_ports(const char *portstring, uint16_t *ports, const char *proto)
unsigned int i;
buffer = strdup(portstring);
if (!buffer) xtables_error(OTHER_PROBLEM, "strdup failed");
if (buffer == NULL)
xtables_error(OTHER_PROBLEM, "strdup failed");
for (cp=buffer, i=0; cp && i<IPT_PKNOCK_MAX_PORTS; cp=next, i++)
for (cp=buffer, i=0; cp != NULL && i<IPT_PKNOCK_MAX_PORTS; cp=next, i++)
{
next=strchr(cp, ',');
if (next) *next++='\0';
if (next != NULL)
*next++ = '\0';
ports[i] = xtables_parse_port(cp, proto);
}
if (cp) xtables_error(PARAMETER_PROBLEM, "too many ports specified");
if (cp != NULL)
xtables_error(PARAMETER_PROBLEM, "too many ports specified");
free(buffer);
return i;
@@ -99,7 +102,7 @@ check_proto(uint16_t pnum, uint8_t invflags)
if ((proto = proto_to_name(pnum)) != NULL)
return proto;
else if (!pnum)
else if (pnum == 0)
xtables_error(PARAMETER_PROBLEM, PKNOCK "needs `-p tcp' or `-p udp'");
else
xtables_error(PARAMETER_PROBLEM, PKNOCK "only works with TCP and UDP.");