From f1dc7f960c78a612e0a35dbba8a85fd038ba71ce Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Wed, 7 Oct 2009 23:59:41 +0200 Subject: [PATCH] pknock: peer can never be NULL in the hash iterator Given that pos is non-NULL, list_entry won't make it NULL. --- extensions/xt_pknock.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/extensions/xt_pknock.c b/extensions/xt_pknock.c index 7e50162..8d466ad 100644 --- a/extensions/xt_pknock.c +++ b/extensions/xt_pknock.c @@ -509,12 +509,9 @@ remove_rule(struct xt_pknock_mtinfo *info) hashtable_for_each_safe(pos, n, rule->peer_head, peer_hashsize, i) { peer = list_entry(pos, struct peer, head); - - if (peer != NULL) { - pk_debug("DELETED", peer); - list_del(pos); - kfree(peer); - } + pk_debug("DELETED", peer); + list_del(pos); + kfree(peer); } if (rule->status_proc != NULL)