From f757049112655d7fee5037307b418aaa6b0550dd Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Sun, 24 Oct 2010 16:35:12 +0200 Subject: [PATCH] xt_iface: reduce indent by early return --- extensions/xt_iface.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/extensions/xt_iface.c b/extensions/xt_iface.c index 4bf5486..ce04915 100644 --- a/extensions/xt_iface.c +++ b/extensions/xt_iface.c @@ -53,16 +53,17 @@ static bool xt_iface_mt(const struct sk_buff *skb, #else dev = dev_get_by_name(info->ifname); #endif - retval = dev != NULL; - if (retval) { - for (i = 0; i < ARRAY_SIZE(xt_iface_lookup) && retval; ++i) { - if (info->flags & xt_iface_lookup[i].iface_flag) - retval &= dev->flags & xt_iface_lookup[i].iff_flag; - if (info->invflags & xt_iface_lookup[i].iface_flag) - retval &= !(dev->flags & xt_iface_lookup[i].iff_flag); - } - dev_put(dev); + if (dev == NULL) + return false; + + retval = true; + for (i = 0; i < ARRAY_SIZE(xt_iface_lookup) && retval; ++i) { + if (info->flags & xt_iface_lookup[i].iface_flag) + retval &= dev->flags & xt_iface_lookup[i].iff_flag; + if (info->invflags & xt_iface_lookup[i].iface_flag) + retval &= !(dev->flags & xt_iface_lookup[i].iff_flag); } + dev_put(dev); return retval; }