From d4f911b7b569327bed292ff7a315d8ff6be8497d Mon Sep 17 00:00:00 2001 From: youxingzhi Date: Mon, 30 Dec 2019 12:17:51 +0800 Subject: [PATCH] =?UTF-8?q?test:=20=F0=9F=92=8D=20add=20some=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gitignore | 2 + dev/App.vue | 7 + jest.config.js | 8 +- package.json | 3 +- src/Tree.js | 2 +- src/VueTreeList.vue | 21 +-- tests/unit/__snapshots__/example.spec.js.snap | 72 --------- tests/unit/__snapshots__/render.spec.js.snap | 143 ++++++++++++++++++ tests/unit/drag.spec.js | 87 +++++++++++ tests/unit/operation.spec.js | 86 +++++++++++ .../unit/{example.spec.js => render.spec.js} | 30 ++-- 11 files changed, 359 insertions(+), 102 deletions(-) delete mode 100644 tests/unit/__snapshots__/example.spec.js.snap create mode 100644 tests/unit/__snapshots__/render.spec.js.snap create mode 100644 tests/unit/drag.spec.js create mode 100644 tests/unit/operation.spec.js rename tests/unit/{example.spec.js => render.spec.js} (59%) diff --git a/.gitignore b/.gitignore index a0dddc6..01fd251 100644 --- a/.gitignore +++ b/.gitignore @@ -19,3 +19,5 @@ yarn-error.log* *.njsproj *.sln *.sw? + +coverage diff --git a/dev/App.vue b/dev/App.vue index 09f30fb..e163fd7 100644 --- a/dev/App.vue +++ b/dev/App.vue @@ -70,31 +70,38 @@ }, methods: { onDel (node) { + // eslint-disable-next-line no-console console.log(node) node.remove() }, onChangeName (params) { + // eslint-disable-next-line no-console console.log(params) }, onAddNode (params) { + // eslint-disable-next-line no-console console.log(params) }, onClick (params) { + // eslint-disable-next-line no-console console.log(params) }, drop: function ({node, src, target}) { + // eslint-disable-next-line no-console console.log('drop', node, src, target) }, dropBefore: function ({node, src, target}) { + // eslint-disable-next-line no-console console.log('drop-before', node, src, target) }, dropAfter: function ({node, src, target}) { + // eslint-disable-next-line no-console console.log('drop-after', node, src, target) }, diff --git a/jest.config.js b/jest.config.js index e66cb0e..87cc90c 100644 --- a/jest.config.js +++ b/jest.config.js @@ -1,4 +1,6 @@ module.exports = { - preset: "@vue/cli-plugin-unit-jest", - snapshotSerializers: ["jest-serializer-vue"] -}; + preset: '@vue/cli-plugin-unit-jest', + snapshotSerializers: ['jest-serializer-vue'], + collectCoverageFrom: ['src/**/*.{js,vue}'], + coveragePathIgnorePatterns: ['src/index.js'] +} diff --git a/package.json b/package.json index 1c53d5e..cd72cfc 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,8 @@ "scripts": { "serve": "vue-cli-service serve dev", "build": "vue-cli-service build --target lib src/index.js", - "test:unit": "vue-cli-service test:unit", + "test:unit": "vue-cli-service test:unit --watch", + "test:coverage": "vue-cli-service test:unit --coverage", "lint": "vue-cli-service lint", "commit": "npx git-cz", "prepublish": "npm run build" diff --git a/src/Tree.js b/src/Tree.js index 083f946..facc879 100644 --- a/src/Tree.js +++ b/src/Tree.js @@ -115,7 +115,7 @@ TreeNode.prototype._beforeInsert = function (target) { return false } - // cannot move ancestor to child + // cannot insert ancestor to child if (this.isTargetChild(target)) { return false } diff --git a/src/VueTreeList.vue b/src/VueTreeList.vue index d670733..61885f9 100644 --- a/src/VueTreeList.vue +++ b/src/VueTreeList.vue @@ -1,12 +1,17 @@