geoip: simplify unpacking start/end tuples from database

Use unpack() to separate start/end instead of substr().

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
This commit is contained in:
Philip Prindeville
2020-04-20 01:17:14 +02:00
committed by Jan Engelhardt
parent 4b43df69f5
commit 74fcd4a2ae

View File

@@ -53,8 +53,9 @@ foreach my $cc (@ARGV) {
binmode($fh);
while (($bytes = read($fh, $buffer, AF_INET_SIZE * 2)) == AF_INET_SIZE * 2) {
my $start = inet_ntop(AF_INET, substr($buffer, 0, AF_INET_SIZE));
my $end = inet_ntop(AF_INET, substr($buffer, AF_INET_SIZE));
my ($start, $end) = unpack('a4a4', $buffer);
$start = inet_ntop(AF_INET, $start);
$end = inet_ntop(AF_INET, $end);
print $start, '-', $end, "\n";
}
close($fh);
@@ -75,8 +76,9 @@ foreach my $cc (@ARGV) {
binmode($fh);
while (($bytes = read($fh, $buffer, AF_INET6_SIZE * 2)) == AF_INET6_SIZE * 2) {
my $start = inet_ntop(AF_INET6, substr($buffer, 0, AF_INET6_SIZE));
my $end = inet_ntop(AF_INET6, substr($buffer, AF_INET6_SIZE));
my ($start, $end) = unpack('a16a16', $buffer);
$start = inet_ntop(AF_INET6, $start);
$end = inet_ntop(AF_INET6, $end);
print $start, '-', $end, "\n";
}
close($fh);