feat: unified bug fixes, tutor lifecycle, and room editor refactor #2

Merged

mpuchstein merged 7 commits from feature/unified-fixes-room-editor into main 2026-05-05 03:04:26 +02:00

Conversation 0 Commits 7 Files Changed 30 +4290 -332

mpuchstein commented 2026-05-05 00:49:04 +02:00

Owner

Copy Link

• Security: Fixed RUSTSEC-2023-0071 via aws_lc_rs
• API: Fixed empty 200 body parsing and check-in typing
• Tutors: Added is_active flag, safe deletion with 409 conflict checks, and admin toggle UI
• Rooms: Migrated room layouts from pixel to grid scale, added additive layout validators
• UI: Improved RoomCanvas with dynamic sizing, interactive editing, snap-to-grid
• App: Replaced static SeatMap component with dynamic RoomCanvas across live and checkin views

- Security: Fixed RUSTSEC-2023-0071 via aws_lc_rs - API: Fixed empty 200 body parsing and check-in typing - Tutors: Added is_active flag, safe deletion with 409 conflict checks, and admin toggle UI - Rooms: Migrated room layouts from pixel to grid scale, added additive layout validators - UI: Improved RoomCanvas with dynamic sizing, interactive editing, snap-to-grid - App: Replaced static SeatMap component with dynamic RoomCanvas across live and checkin views

mpuchstein added 1 commit 2026-05-05 00:49:05 +02:00

feat: unified bug fixes, tutor lifecycle, and room editor refactor ... 3b9c755e39

- Security: Fixed RUSTSEC-2023-0071 via aws_lc_rs
- API: Fixed empty 200 body parsing and check-in typing
- Tutors: Added is_active flag, safe deletion with 409 conflict checks, and admin toggle UI
- Rooms: Migrated room layouts from pixel to grid scale, added additive layout validators
- UI: Improved RoomCanvas with dynamic sizing, interactive editing, snap-to-grid
- App: Replaced static SeatMap component with dynamic RoomCanvas across live and checkin views

mpuchstein added 1 commit 2026-05-05 01:28:48 +02:00

fix: address review findings — error handling, migration safety, CI audit ... 827eb63bab

Backend:
- migration 003: apply pixel→grid transform per-element (CASE WHEN > 50)
  instead of per-row, preventing double-conversion of mixed-scale rooms;
  skip empty arrays via json_array_length guard to avoid NULL assignment
- attendance.rs: log layout JSON parse errors instead of silently
  swallowing them with .ok()
- tutors.rs: check rows_affected() in set_tutor_active and return 404
  for non-existent IDs; remap FK constraint errors on delete to 409
  so concurrent inserts between conflict-check and DELETE don't surface
  as 500

Frontend:
- live/[slotId]: expose polling failures to the tutor via error banner
  instead of only console.error
- s/[code]: split checkin into two try/catch blocks so a successful
  POST followed by a failed reload doesn't report failure to the student;
  fix dead '409' string detection to match actual server error 'seat taken'
- rooms/[roomId]: remove duplicate onMount fetch; add .catch() to $effect
- tutors: expose loadTutors failures via error banner, not just console
- rooms: fix bare catch in createRoom (captures error, shows message);
  add try/catch to onMount rooms load

CI:
- sync cargo audit --ignore RUSTSEC-2023-0071 with Makefile; the advisory
  is in rsa which sqlx-mysql retains in the lock file even when the mysql
  feature is disabled — aws_lc_rs correctly removes it from the active tree

mpuchstein referenced this issue from a commit 2026-05-05 01:55:46 +02:00

fix: address PR #2 review findings across backend and frontend

mpuchstein added 1 commit 2026-05-05 01:55:46 +02:00

fix: address PR #2 review findings across backend and frontend ... 4939838a7f

- Makefile: add SHELL := /bin/bash so test-env.sh pipefail works in CI
- RoomCanvas: fix onElementClick firing on drag start (now fires on mouseup
  for click-in-place only); fix Props type to accept null; guard grid pattern
  against snapStep=0 (invalid SVG); remove unsafe null cast
- live/[slotId]: fix studentNamesBySeat $derived wrapping a function instead
  of a value — reactivity was broken, map never updated
- s/[code]: block clicks on occupied seats before hitting the backend;
  pass occupiedSeatIds to confirmed-view RoomCanvas; clear errorMsg on retry
- rooms/+page: replace alert() in deleteRoom with inline errorMsg state
- rooms/[roomId]: replace deprecated .substr with .slice
- courses.rs: assign_tutor uses fetch_optional → 404 on unknown tutor_id
  instead of propagating RowNotFound as 500
- rooms.rs: delete_room returns 404 when room does not exist; replace
  fract() != 0.0 float check with epsilon-based validation
- auth_routes.rs: refresh endpoint re-checks is_active so deactivated tutors
  cannot obtain new access tokens; fix test INSERT to include is_active
- tutors.rs: wrap delete_tutor reference checks and DELETE in a transaction
- attendance.rs: replace #[allow(clippy::type_complexity)] with type alias
- migrations/003: document > 50 heuristic precondition

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mpuchstein added 1 commit 2026-05-05 02:02:32 +02:00

fix: replace per-element CASE WHEN in migration 003 with WHERE EXISTS ... 24f2556c9d

Instead of applying a per-element heuristic (skip if value ≤ 50), identify
pixel-scale rooms at the row level with WHERE EXISTS, then convert all
elements unconditionally. Eliminates the risk of mixed-scale elements within
the same room.

mpuchstein added 1 commit 2026-05-05 02:24:31 +02:00

fix: implement random-port discovery for CI E2E backend ... 681b43174b

When PORT=0, the backend now writes its actual bound port to
data/test/.port. test-env.sh reads that file when TT_TEST_PORT=0
so all targets (test-up, test-reset, test-down) resolve the real URL.
test-up waits for .port to appear before the health-check loop.

mpuchstein added 1 commit 2026-05-05 02:40:35 +02:00

fix: track Cargo.lock so Docker CI build can copy it ... ab9d1fc547

Cargo.lock was in .gitignore, making it absent from the git checkout
that CI builds the Docker image from — COPY backend/Cargo.lock failed.

mpuchstein added 1 commit 2026-05-05 02:52:28 +02:00

fix: run svelte-kit sync before svelte-check in Docker build ... 39341ce69d

.svelte-kit/tsconfig.json is gitignored and must be generated at
build time — svelte-check cannot run without it.

mpuchstein merged commit 39341ce69d into main 2026-05-05 03:04:26 +02:00

mpuchstein deleted branch feature/unified-fixes-room-editor 2026-05-05 03:04:26 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

mpuchstein

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mpuchstein/tutortool#2